New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot wrap FallbackComponent with styled components #61
Comments
Thanks for this. Could you make a reproduction in a codesandbox? |
I have created this example https://codesandbox.io/s/quiet-fast-g7747?file=/src/App.js What do you think if we use |
That sounds good to me! Thanks @marcosvega91. |
fix bvaughn#61 To fix the issue I have used the library from facebook 'react-is'. With this library we can check if the FallbackComponent is a real component. A component is not alwasy a function, but can be also object
* test: add failing tests * chore: add react-is as dep * fix: support all kind of component Closes #61 To fix the issue I have used the library from facebook 'react-is'. With this library we can check if the FallbackComponent is a real component. A component is not alwasy a function, but can be also object * chore: remove react-is dep * fix: check FallbackComponent if is defined instead of using react-is * test: simplify test after review
🎉 This issue has been resolved in version 2.3.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
react-error-boundary
version: 2.3.0node
version: 12.16.1npm
version: 6.13.4Relevant code or config
What you did: wrapped FallbackComponent in styled-components styled() method.
What happened:
The text was updated successfully, but these errors were encountered: