-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the use of a class for the non highlighted #27
Conversation
There is a issue that doesn’t allow the user use a specific class for the elements that has no highlighted texts.
|
Yes, but it should be applied to the children as well, don you think? It's creating
The main idea is that the user would not need to create extra classes, but, inherit it from the actual implementation. |
That would limit what you're able to do with the class. 😕 Plus it wouldn't be a backwards-compatible change. |
how about a new prop name? Please, take a look in the new implementation. |
Hm. I guess I don't object, although I think The props docs would also need to be updated. |
I believe that now it's correct @bvaughn |
Thank you so much Brian. You did a great job! |
Cool. Thanks for the contribution. 😄 I apologize, but last night when you opened this PR I was watching TV with my wife and I didn't give the property name we discussed enough thought. This feature is out as v0.8.0! |
There is a issue that doesn’t allow the user use a specific class for
the elements that has no highlighted texts.