Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added renderMenuContainer prop. #118

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tgreblicki
Copy link

Exposes additional property which accepts function for decorating menuRendered.

As react-virtualized-select uses menuRenderer prop for rendering virtualized dropdown. This property allows easy way to add custom content around dropdown.

@sbauch
Copy link

sbauch commented Sep 13, 2018

I could really use something like this, any chance of it being merged?

One alternative approach that may warrant consideration is exposing the menuRenderer prop itself, and using the existing function by default.

@bvaughn
Copy link
Owner

bvaughn commented Sep 13, 2018

Realistically, I won't have time to review/merge or release an updated version of this library any time soon. I'm swamped with higher priority stuff. I'm sorry.

@sbauch
Copy link

sbauch commented Sep 13, 2018

Completely understand, thanks for a great lib!

@tgreblicki im going to fork your fork and make a few changes that will allow me to install from github 🎉

@bvaughn
Copy link
Owner

bvaughn commented Sep 13, 2018

Thanks for being so understanding 😄

As a possible alternative: if one of you would like to be added to this repo/NPM package, I'd welcome another maintainer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants