Fix #1159: CollectionView scrollTop/scrollLeft

Props scrollTop/scrollLeft are only applied to CollectionView when this.state.scrollPositionChangeReason is REQUESTED, but getDerivedStateFromProps was not setting scrollPositionChangeReason. This meant that these props were not being applied to the view.
bvaughn · Jun 17, 2020 · f40bc0d · f40bc0d
1 parent 9ce12be
commit f40bc0d
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/source/Collection/CollectionView.js b/source/Collection/CollectionView.js
@@ -193,6 +193,7 @@ class CollectionView extends React.PureComponent {
       return {
         scrollLeft: 0,
         scrollTop: 0,
+        scrollPositionChangeReason: SCROLL_POSITION_CHANGE_REASONS.REQUESTED,
       };
     } else if (
       nextProps.scrollLeft !== prevState.scrollLeft ||
@@ -207,6 +208,7 @@ class CollectionView extends React.PureComponent {
           nextProps.scrollTop != null
             ? nextProps.scrollTop
             : prevState.scrollTop,
+        scrollPositionChangeReason: SCROLL_POSITION_CHANGE_REASONS.REQUESTED,
       };
     }