Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always-on scrollbars cause FlexTable headers to become slightly misaligned #80

Closed
bvaughn opened this issue Feb 3, 2016 · 2 comments
Closed

Comments

@bvaughn
Copy link
Owner

bvaughn commented Feb 3, 2016

Steps to reproduce:

  1. Create a FlexTable where the 1st column is set to grow and subsequent columns are fixed-width.
  2. Set OS scrollbars to be always-on: System Preferences > General:

screen shot 2016-02-03 at 12 11 24 pm

Table headers become offset by the width of the scrollbar:
screen-shot-2016-02-03-at-12 30 54-pm

This can be seen by rearranging the column orders in the FlexTable example:
screen shot 2016-02-04 at 8 49 23 am

Possible solutions:

  • Add componentDidMount check to determine scrollbar size (offsetWidth - clientWidth) and subtract from width of table row when scrollbar is visible.
  • Implement fixed-headers in Grid component (as discussed on version 5 roadmap) and use them instead.
@bvaughn
Copy link
Owner Author

bvaughn commented Feb 3, 2016

It's not clear to me how common this use-case is and if fixing it is worth the effort.

bvaughn added a commit that referenced this issue Feb 4, 2016
Fix FlexTable header alignment problem due to always-on scrollbars.
@bvaughn
Copy link
Owner Author

bvaughn commented Feb 4, 2016

Fixed via PR #81

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant