add get size helpers #1022
Merged
add get size helpers #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nihgwu correct me if I'm wrong. But can't you just calculate those values using the required props that you passed into columnCount
columnWidth
rowCount
rowWidth |
|
@wuweiweiwu |
|
@TrySound Any opinion on this? |
|
@nihgwu I see. Thanks for clarifying :) |
|
I think it's good. Let's wait until #1009 will be landed in master. |
TrySound
approved these changes
Mar 13, 2018
|
@TrySound Thanks, I'm accessing the private instance right now |
wuweiweiwu
requested changes
May 8, 2018
source/Grid/Grid.js
Outdated
| * Gets estimated total rows' height. | ||
| */ | ||
| getTotalRowsHeight() { | ||
| return this._rowSizeAndPositionManager.getTotalSize(); |
There was a problem hiding this comment.
rowSizeAndPositionManager is now stored in this.state.instanceProps.
|
@wuweiweiwu updated |
|
Awesome! I'll make sure tests pass tonight and I'll merge this! Thanks @nihgwu |
|
Tests all pass locally, merging. |
wuweiweiwu
approved these changes
May 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm creating a
Tablebased onGrid, it supports tree data and auto growable height, I need to get the total rows' height after expanding/adding/removing or I have to calculate every time it changes manually, right now I have to access the private_rowSizeAndPositionManagerto get the total height