Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pre-commit to run prettier and lint #1080

Closed
wants to merge 1 commit into from
Closed

add pre-commit to run prettier and lint #1080

wants to merge 1 commit into from

Conversation

bardiarastin
Copy link
Contributor

this will add running prettier and lint before committing, @wuweiweiwu what do you think about adding test too ?

@bardiarastin bardiarastin mentioned this pull request Apr 17, 2018
Closed
@TrySound
Copy link
Collaborator

@bvaughn What is the reason you don't like to format code on precommit?

@bvaughn
Copy link
Owner

bvaughn commented Apr 21, 2018

I don't really object to this.

@TrySound TrySound mentioned this pull request Apr 21, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bardiarastin @TrySound @bvaughn