Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Table._setScrollbarWidth by adding public function Table.getScrollbarWidth #1411

Merged
merged 2 commits into from
Sep 5, 2019

Conversation

RoosDaniel
Copy link
Contributor

For uses where a custom (external) header-row has to be used, there's little support for matching its width to the Table's width. Most of it can be circumvented by summing Column widths, but there's no way to get the scrollbarWidth used since the method _setScrollbarWidth does both the calculation and setState parts.

With this change, implementations that rely on matching this repo's internal _setScrollbarWidth function with an external (almost identical) function could instead use getScrollbarWidth.

@codecov-io
Copy link

codecov-io commented Aug 9, 2019

Codecov Report

Merging #1411 into master will decrease coverage by 0.04%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1411      +/-   ##
==========================================
- Coverage    90.4%   90.35%   -0.05%     
==========================================
  Files          59       59              
  Lines        1740     1742       +2     
==========================================
+ Hits         1573     1574       +1     
- Misses        167      168       +1
Impacted Files Coverage Δ
source/Table/Table.js 88.39% <87.5%> (-0.7%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 710fc67...e37832b. Read the comment docs.

Copy link
Collaborator

@wuweiweiwu wuweiweiwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@wuweiweiwu
Copy link
Collaborator

wuweiweiwu commented Sep 5, 2019

minor release

@wuweiweiwu wuweiweiwu merged commit a390b2a into bvaughn:master Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants