Add center option for scrollToAlignment #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // 100 rows * 20 item height = 2,000 total item height | ||
| // We first scroll past the specified cell and then back. | ||
| // The minimum amount of scrolling then should leave the specified cell in the middle (just scrolled into view). | ||
| // Since alignment is set to "middle" we should scroll past this point until the cell is aligned center. |
|
Nice update! Thanks for the PR. Left some small comments. Docs will also need to be updated (but I can do that if you'd prefer to just focus on the code.) |
|
Thanks @bvaughn. I'll take care of the docs too 😉 |
|
📯 👍 |
added 2 commits
May 23, 2016 16:16
|
Thanks for putting together this PR :) |
|
Version 7.1.2 just released with this feature. |
|
Thank you so much @bvaughn for being so fast 🚀! The work you're doing with react-virtualized is totally awesome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds "center" option to
scrollToAlignmentfor being able to scroll to a cell and display it centered on the container.This is specially useful when scrolling horizontally and want to show a given cell in the middle of the screen (in our use case is the today column in a gantt chart)