Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear cell cache when external scrolling ends #649

Merged

Conversation

leoasis
Copy link
Contributor

@leoasis leoasis commented Apr 11, 2017

With the fix in 9.5.0 for using the cell cache inWindowScroller (https://github.com/bvaughn/react-virtualized/blob/master/CHANGELOG.md#950), another bug was unveiled:

Since the Grid when used with WindowScroller does not emit onScroll events when the user scrolls, the cell cache is never cleaned up because the _debounceScrollEnded function is never called.

This PR fixes that by detecting if props.isScrolling changed from true to false, and call this._debounceScrollEnded() in that case.

@bvaughn bvaughn merged commit 9561221 into bvaughn:master Apr 12, 2017
@bvaughn
Copy link
Owner

bvaughn commented Apr 12, 2017

Thanks for this contribution! Released as 9.7.3

@leoasis leoasis deleted the clear_cell_cache_with_external_scroll branch April 12, 2017 15:14
@leoasis
Copy link
Contributor Author

leoasis commented Apr 12, 2017

Thanks for accepting it and for this library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants