Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on bad value passed to registerChild in WindowScroller #949

Merged
merged 1 commit into from Jan 6, 2018

Conversation

TrySound
Copy link
Collaborator

@TrySound TrySound commented Jan 5, 2018

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #949 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #949      +/-   ##
==========================================
+ Coverage   90.37%   90.39%   +0.01%     
==========================================
  Files          57       57              
  Lines        1632     1634       +2     
==========================================
+ Hits         1475     1477       +2     
  Misses        157      157
Impacted Files Coverage Δ
source/WindowScroller/WindowScroller.js 98.46% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4496687...2b88171. Read the comment docs.

@TrySound TrySound merged commit 8a73141 into master Jan 6, 2018
@TrySound TrySound deleted the window-scroller-warn-on-bad-child branch January 6, 2018 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants