Make rowIndex and columnIndex optional #174
Conversation
src/createGridComponent.js
Outdated
| horizontalScrollbarSize | ||
| ), | ||
| scrollLeft: | ||
| columnIndex !== undefined && columnIndex >= 0 |
There was a problem hiding this comment.
Well, it's not needed for this feature, but negative indexes will not produce valid results, especially with VariableSizeGrid. I can remove the check if you prefer to leave the behaviour undefined.
There was a problem hiding this comment.
@bvaughn Specifically, for VariableSizeGrid, itemMetadata will be undefined, which will throw an error when calculating maxOffset.
jgoz
force-pushed
the
173-optional-scrollItem-index
branch
from
d4a9dec
to
665957e
Compare
|
@bvaughn Removed the |
| // Scroll down to row 10, without changing scrollLeft | ||
| rendered.getInstance().scrollToItem({ rowIndex: 10, align: 'auto' }); | ||
| // Scroll left to column 0, without changing scrollTop | ||
| rendered.getInstance().scrollToItem({ columnIndex: 0, align: 'auto' }); |
There was a problem hiding this comment.
You aren't testing anything between these scrollToItem calls. That seems not great.
There was a problem hiding this comment.
Whoops. I misremembered how my own tests were written 😆 you're expecting on the mock calls below. 👍
|
Just released with v1.7.0 |
Closes #173.
Update
scrollToItemto makerowIndexandcolumnIndexoptional. If unspecified (or invalid, e.g., negative value), the current value forscrollToporscrollLeftwill be used.