Change the pointer events value to be valid #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvaughn
approved these changes
Apr 13, 2019
| @@ -326,7 +326,7 @@ export default function createListComponent({ | |||
| ref: innerRef, | |||
| style: { | |||
| height: isHorizontal ? '100%' : estimatedTotalSize, | |||
| pointerEvents: isScrolling ? 'none' : '', | |||
| pointerEvents: isScrolling ? 'none' : null, | |||
There was a problem hiding this comment.
Oh weird 😮I would have sworn the else condition was undefined
|
The browser seems to drop an empty-string |
|
v1.8.1 |
|
I haven't noticed any impact. I aim at zero error reported by w3.org validator :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have found the issue in https://validator.w3.org/nu/?doc=https%3A%2F%2Fnext.material-ui.com%2Fdemos%2Flists%2F. We have a demo with this library.
(n°1 is an issue with Next.js)