Add support for RTL in Edge #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvaughn
reviewed
Jun 14, 2019
src/createGridComponent.js
Outdated
| case 'negative': | ||
| outerRef.scrollLeft = -scrollLeft; | ||
| break; | ||
| case 'reverse': |
There was a problem hiding this comment.
These labels are confusing to me. Especially calling a non-spec-compliant behavior "default". I wonder if there is a more meaningful name we could pick?
So I think we're differentiating between:
- spec-compliant browsers: 0 ... -N
- Chrome: N ... 0
- non-Chromium Edge: 0 ... N
Maybe the following labels would be a bit more meaningful?
- negative: (0 ... -N)
- positive-descending: (N ... 0)
- positive-ascending: (0 ... N)
|
I'm happy with the renames. |
|
Published in 1.8.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #159
This fix adds support for non-bleeding edge Edge which uses a different positive scrollLeft when in RTL compared to the positive scrollLeft that Chrome uses.