support for the UMD package format #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrySound
suggested changes
Jul 5, 2019
bvaughn
reviewed
Jul 5, 2019
|
ok, all clear! I'll resubmit with your suggestions + the yarn lint failures. |
|
Just push in this branch |
emmanueltouzery
force-pushed
the
umd_package
branch
from
f063cd2
to
ac3bd7c
Compare
|
I pushed a new version! |
TrySound
approved these changes
Jul 5, 2019
bvaughn
approved these changes
Jul 6, 2019
|
Thanks for the code review, @TrySound. Published 1.8.5 |
darrenowensplancom
pushed a commit
to darrenowensplancom/react-window
that referenced
this pull request
Jan 9, 2020
* Added UMD (dev and prod) build (@emmanueltouzery - bvaughn#281)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw in #232 that you'd consider a PR to support UMD package generation, and it would be very important for us to have a UMD package of react-window honestly.
So here's a PR. I tested the generated UMD with our app and it seems to work just fine. There are two open questions maybe:
I tested by copying the generated JS files in our app. We just need to be sure that the files will indeed be in the NPM package. I believe they'll be, but...
If you want to just provide UMD support with the minimal extra dependencies, maybe you don't want to "uglify" (minimize) the output. For our purpose we don't need a minimized UMD, but some people may expect it. So I made two commits, the uglify support is in the second commit. So you can take it in, or not. I checked and formik for instance ships minified UMDs.