Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declared package side effects free #385

Merged
merged 1 commit into from
Dec 31, 2019
Merged

Declared package side effects free #385

merged 1 commit into from
Dec 31, 2019

Commits on Nov 21, 2019

  1. Declared package side effects free 

    This sets the package.json field sideEffects to false. This allows for better tree shaking by downstream consumers, see https://webpack.js.org/guides/tree-shaking/#mark-the-file-as-side-effect-free for more information.

I skimmed over all included files and I did not see anything that would count following webpack's definition of tree shaking during a production build.

There is one side effect, but I believe its only used in development builds, so it would be okay to tree shake:
https://github.com/bvaughn/react-window/blob/master/src/createListComponent.js#L127-L136

For more details on how this field works and why it matter see the discussion here: react-dnd/react-dnd#1577
    @maclockard
    maclockard committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    71e0ab7 View commit details
    Browse the repository at this point in the history