Skip to content

Commit

Permalink
Removed stale comment
Browse files Browse the repository at this point in the history
  • Loading branch information
Brian Vaughn committed Jul 15, 2020
1 parent c93d74a commit 2e81752
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions packages/react-reconciler/src/ReactFiberBeginWork.new.js
Expand Up @@ -2990,11 +2990,6 @@ function bailoutOnAlreadyFinishedWork(

// Check if the children have any pending work.
if (!includesSomeLane(renderLanes, workInProgress.childLanes)) {
// TODO (effects) The case we are trying to handle is an error thrown during commit,
// and we replay the work, even though we skip render phase (by bailing out)
// we don't want to bailout on commit effects too.
// However, this check seems overly aggressive in some cases.

// The children don't have any work either. We can skip them.
// TODO: Once we add back resuming, we should check if the children are
// a work-in-progress set. If so, we need to transfer their effects.
Expand Down

0 comments on commit 2e81752

Please sign in to comment.