Refactored useMutableSource to use update queue

For now, the hook just uses useEffect and useState under the hood. This probably makes it a little less effcient at runtime but perhaps a little smaller in code size. This change ended up being a little larger than I would have assumed. Maybe that indicates there is room for improvement in my initial implementation.
bvaughn · Feb 20, 2020 · 7de01f1 · 7de01f1
1 parent c8689d7
commit 7de01f1
Show file tree

Hide file tree

Showing 6 changed files with 3,346 additions and 3,307 deletions.
diff --git a/packages/react-reconciler/src/ReactFiberCompleteWork.js b/packages/react-reconciler/src/ReactFiberCompleteWork.js
@@ -28,7 +28,6 @@ import type {
 import type {SuspenseContext} from './ReactFiberSuspenseContext';
 
 import {now} from './SchedulerWithReactIntegration';
-import {resetWorkInProgressVersions as resetMutableSourceWorkInProgressVersions} from './ReactMutableSource';
 
 import {
   IndeterminateComponent,
@@ -661,7 +660,6 @@ function completeWork(
       return null;
     }
     case HostRoot: {
-      resetMutableSourceWorkInProgressVersions();
       popHostContainer(workInProgress);
       popTopLevelLegacyContextObject(workInProgress);
       const fiberRoot = (workInProgress.stateNode: FiberRoot);