Primitive.notOneOf() Implementation #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnaputi253
changed the title
bvego
reviewed
Jul 2, 2019
src/NopePrimitive.ts
Outdated
| @@ -61,6 +61,26 @@ abstract class NopePrimitive<T> implements IValidatable<T> { | |||
| return this.test(rule); | |||
| } | |||
|
|
|||
| public notOneOf(options: Array<T | NopeReference | Nil>, message = 'Invalid Option') { | |||
| const resolveNopeRef = (option: T | NopeReference | Nil, context?: { [key: string]: any}) => { | |||
There was a problem hiding this comment.
Would it be possible to extract this to the ./utils.ts file for both oneOf and notOneOf pretty please? 😄
|
The implementation is great, thanks! I left a small comment that I'd like to be resolved so we don't have duplicate code Thanks! 😄 |
|
Went ahead and moved the duplicate code to the utils.ts file 😄 |
|
Awesome, great job man! Thank you so much! If you have any feature ideas or things that you would like to see feel free to open up an issue 😄 Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's the implementation for the method along with the tests for it. Let me know if any fixes are needed!