Add primitive().notOneOf()

[bvego]

Just like the .oneOf method, but with reverse logic. Check if the entry is not within the options

[jnaputi253]

Wouldn't mind giving a try at the issue.

[bvego]

Sure thing! 😄

Assigned the issue to you!

Thanks for contributing!

[jnaputi253]

Is it fine if I make a branch or should I fork the repo?

And happy to help! First time with TypeScript so it might take me a little bit to get used to typed JavaScript :)

[bvego]

I'd prefer if you'd fork the repo!

If you get stuck on something feel free to ask! 😄

[jnaputi253]

+1

[jnaputi253]

For the #resolveNopeRef() method, would it be fine to make it a private class-level method since both #oneOf() and #notOneOf() would be using it?

[bvego]

It sure does, but I'm afraid if we put it in the Primitive class that time will come when we'll have more complex classes that don't extend the class Primitive - that's why I made it a util 😄

[jnaputi253]

Sounds good!

[jnaputi253]

As a heads-up, gonna head out to work. The implementation is done and I wrote a couple of unit tests for it so far. I'll go ahead and wrap up the tests tonight (or later today if I can find the free time) and create a PR for it.

[bvego]

Awesome man, thanks a lot! have a great day t work 😄

[jnaputi253]

Started the PR.

Let me know if anything needs to be fixed 😄

[bvego]

Thanks for your contribution! Closing this issue since its implemented 😄