Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exports of ogv-support.js/ogv-version.js + some JS build clean-up #620

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fix exports of ogv-support.js/ogv-version.js + some JS build clean-up #620

wants to merge 6 commits into from

Commits on Nov 20, 2022

  1. Use 'prepack' script instead of the deprecated 'prepublish' 

    I _think_ this is the desired behavior, since in my opinion it's weird to build a bunch of C code when running `npm install` with the expectation of just installing the node_modules. The command will now only run before `npm pack` and `npm publish`.

See https://docs.npmjs.com/cli/v9/using-npm/scripts#life-cycle-scripts
    @Mesoptier
    Mesoptier committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    90faa61 View commit details
    Browse the repository at this point in the history

  2. Automatically update package-lock.json

    @Mesoptier
    Mesoptier committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    0a20233 View commit details
    Browse the repository at this point in the history

  3. Update caniuse-lite 

    See https://github.com/browserslist/update-db#why-you-need-to-call-it-regularly
    @Mesoptier
    Mesoptier committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    a9b1055 View commit details
    Browse the repository at this point in the history

  4. Specify webpack mode on a per-script basis

    @Mesoptier
    Mesoptier committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    7f7c766 View commit details
    Browse the repository at this point in the history

  5. Update main webpack entries to expose exports directly on window vi… 

    …a UMD

Previously, the compiled ogv-support.js and ogv-version.js files would not actually export anything in AMD/CommonJS and only expose directly on the global object.
    @Mesoptier
    Mesoptier committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    96b8d1f View commit details
    Browse the repository at this point in the history

  6. Remove manual assignment of exports on window object 

    This is now automatically handled by UMD when the scripts are loaded outside an AMD/CommonJS module environment.
    @Mesoptier
    Mesoptier committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    a2c5237 View commit details
    Browse the repository at this point in the history