Eliminate warnings in tests #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the `args` parameter is not set when calling TestCase.assertParseArgsRaises, `args` is set to `sys.argv`, which makes the test output dependent on how the test suit was called. For example, it would succeed for `pytest`, but fail with `pytest -v` or `pytest -k testConfigOrEnvValueErrors`. Change signature of assertParseArgsRaises() to ensure args is always present, and all other parameters are named.
pytest tries to collect tests from TestHelpFormattingMetaclass, and test_main, and raises a warning when it finds it's not a test class nor test function. Renaming TestHelpFormattingMetaclass and test_main prevents pytest from trying.
ArgumentParser._open_config_files() opens multiple configuration files, and returns the file streams. If one of the file open() operations fail, and exception is raised. E.g. file not found. However, this never returns nor closes the previously opened files, leaving dangling file pointers. This commit fixes the issue by closing previously opened config files when an exception occurs.
The file handle `cfg_f` in `testConstructor_WriteOutConfigFileArgs`, `testConstructor_WriteOutConfigFileArgs2` and `testConstructor_WriteOutConfigFileArgsLong` was never closed. Both unittest and `pytest -Wd` reported this as a warning.
Capture output of print_values, instead of sending the irrelevant output to stderr. Also add a superficial verification that it contains relevant output.
|
This PR closes #213, which contains further details. |
This was referenced Feb 25, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix all warnings and errors in the test suite. All test can now be run as either
python setup.py testorpytest. Even in most verbosepytest -r A -W d.See #213 or individual commits for details.