Moved all syntax-related decisions to ConfigFileParser subclasses. Added YAMLConfigFileParser #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 11, 2015
|
Just a note to say that I encountered #26 and switched my package install to point at this branch. Has been working without error since. I hope you consider releasing soon. Thank you for the great work! |
bw2
added a commit
that referenced
this pull request
Jan 19, 2016
Moved all syntax-related decisions to ConfigFileParser subclasses. Added YAMLConfigFileParser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @cortesi @lahwaacz @acx2015 @bartekbrak @kuba (and anyone else interested),
It'd be great to get your feedback on this PR which builds on @lahwaacz 's PR #28. It moves all remaining logic involving config file formats into
ConfigFileParsersubclasses. The format can then be specified by just setting the newconfig_file_parser_classconstructor arg (similar to HelpFormatters). Also, there's now a newYAMLConfigFileParseras an alternative to theDefaultConfigFileParser.Depending on feedback (or if there's none during the next week), I'll merge this and create a new release (probably v1.0).
This should also fix #19 and #30 (and also #26 - the fix for that became clear while working on this).