Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Type config on schema #13

Merged
merged 1 commit into from Dec 11, 2019

Conversation

simstern
Copy link
Contributor

Hi,

When using interfaces but never referencing the implemented types in the schema, the concrete types are not scanned and therefore not know to the schema. As a solution those types can be loaded via the type config.

Settings:

Wwwision:
  GraphQL:
    endpoints:
      graphql:
        configTypes:
          - Foo\Bar\Type\Object\HumanType
          - Foo\Bar\Type\Object\DroidType

Does this implementation make sense in the context of this package? Any suggestion for improvement?

The problem is also described here: webonyx/graphql-php#99

Configure types to be loaded as a solution for interface type implementations.
Cf. webonyx/graphql-php#99
Copy link
Owner

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,
thanks for this contribution and sorry for the long delay - my github notifications were configured weirdly..

@bwaidelich bwaidelich merged commit be82a21 into bwaidelich:master Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants