Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't dirty the data when excluding! #150

Merged
merged 2 commits into from
Jul 5, 2020
Merged

Don't dirty the data when excluding! #150

merged 2 commits into from
Jul 5, 2020

Conversation

Gaff
Copy link
Contributor

@Gaff Gaff commented Jun 26, 2020

Ooops!

(Have you thought about separating MutableDocument and ImmutableDocument as separate classes to prevent this kinda thing?).

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 96.945% when pulling e04bbe8 on Gaff:master into 83e3fa6 on bwaldvogel:master.

@bwaldvogel bwaldvogel merged commit 054515c into bwaldvogel:master Jul 5, 2020
@bwaldvogel
Copy link
Owner

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Gaff @coveralls @bwaldvogel @msmerc