Async support follow-up 2 #153
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwaldvogel
reviewed
Jul 11, 2020
core/src/main/java/de/bwaldvogel/mongo/backend/AbstractMongoBackend.java
Outdated
Show resolved
Hide resolved
justinchuch
force-pushed
the
async-support-2
branch
3 times, most recently
from
30b0fe7
to
5ebf29a
Compare
|
@justinchuch: Could you indicate more clearly which part of this PR is the revert? I would prefer to see one or two commits just for the reverts. |
bwaldvogel
requested changes
Jul 27, 2020
core/src/main/java/de/bwaldvogel/mongo/backend/AbstractMongoBackend.java
Outdated
Show resolved
Hide resolved
core/src/main/java/de/bwaldvogel/mongo/backend/AbstractMongoBackend.java
Outdated
Show resolved
Hide resolved
core/src/main/java/de/bwaldvogel/mongo/backend/AbstractMongoCollection.java
Outdated
Show resolved
Hide resolved
| @@ -469,7 +469,7 @@ public QueryResult handleQuery(QueryParameters queryParameters) { | |||
| return writeErrors; | |||
| } | |||
|
|
|||
| private static Document toErrorDocument(MongoServerError e, int index) { | |||
| public static Document toErrorDocument(MongoServerError e, int index) { | |||
There was a problem hiding this comment.
protected would be enough.
Please add the @VisibleForExternalBackends to indicate why it’s not a private method.
There was a problem hiding this comment.
@VisibleForExternalBackends added.
core/src/main/java/de/bwaldvogel/mongo/backend/AbstractMongoDatabase.java
Show resolved
Hide resolved
core/src/main/java/de/bwaldvogel/mongo/backend/AbstractMongoDatabase.java
Outdated
Show resolved
Hide resolved
justinchuch
force-pushed
the
async-support-2
branch
2 times, most recently
from
578b71c
to
129c171
Compare
This reverts commit 9e379e5.
This reverts commit 8481016.
log unknown error unwrap CompletionException enhance error handling
Change method visibility to public for extensibility Add tests to cover synchronous and asynchronous method call
Change method visibility to public for extensibility
Update MongoCollection
Change method visibility to public for extensibility
Change method visibility to public for extensibility
justinchuch
force-pushed
the
async-support-2
branch
from
129c171
to
8109dc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert some of the changes in #149, which are not ready to merge.
Update MongoDatabaseHanlder:
Add method in
AsyncMongoCollectionandMongoCollectionChange method visibility in
AbstractMongoBackend,AbstractMongoDatabase,AbstractMongoCollection,Utilstopublicfor extensibility.