Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't replace frozen strings #72

Merged
merged 1 commit into from
Mar 4, 2018
Merged

Conversation

bbonislawski
Copy link
Contributor

In rails 5.2 these strings are frozen and you cannot replace them. Overrwriting constants generates warnining but I cannot see how to do it better at the moment

@coveralls
Copy link

coveralls commented Dec 15, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling d98a019 on spark-solutions:master into 00af59f on bwillis:master.

@bbonislawski
Copy link
Contributor Author

@bwillis Versioncake doesn't work with rails 5.2. This is fix, can you look into that?

@bwillis
Copy link
Owner

bwillis commented Mar 4, 2018

Thanks for the fix! I think this is good enough for now, I'll get this pulled in and released. Sorry for the delay! 🌈

@bwillis bwillis merged commit 3a2d272 into bwillis:master Mar 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants