Skip to content
This repository has been archived by the owner on May 19, 2021. It is now read-only.

Timeline does not update even though sync is running #45

Open
bwindels opened this issue May 7, 2020 · 1 comment
Open

Timeline does not update even though sync is running #45

bwindels opened this issue May 7, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@bwindels
Copy link
Owner

bwindels commented May 7, 2020

Timeline stopped showing new incoming message. Clicking the room tile again (several times? can't remember) refreshed the timeline. Might have clicked the room tile quite a few times before and/or have scrolled up/filled gaps before this happened.

Confirmed sync was running with the devtools. No errors in the console.

Did something close the timeline (e.g. disposed the TimelineViewModel?) this is on bwindels/reconnect btw.

@bwindels bwindels added the bug Something isn't working label May 7, 2020
bwindels added a commit that referenced this issue May 7, 2020
@bwindels
Copy link
Owner Author

bwindels commented May 7, 2020

I checked several code paths and couldn't think of a way that the timeline would get closed while still looking at it. Added some logging though to see if it happens.

  • the timeline gets closed in SessionViewModel._openRoom when calling disposeTracked.
  • we unsubscribe from the timeline when unmounting the ListView, but that should only happen when emitting a change of the currentRoom a bit later in that method.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant