A few ESLint and Sass-Lint tweaks #171
Conversation
.sass-lint.yml
Outdated
| no-qualifying-elements: 0 | ||
| no-vendor-prefixes: 0 | ||
| property-sort-order: 0 | ||
| shorthand-values: 0 |
There was a problem hiding this comment.
I just compulsively A-z sorted these. nbd.
There was a problem hiding this comment.
IMO, always better to split these kinds of reorgs / sorts into separate commits, because they can obscure actual changes in diffs
| @@ -68,14 +68,14 @@ | |||
| "clean": "rm -rf dist && shx mkdir -p dist/popup", | |||
| "watch": "npm-run-all --parallel watch:*", | |||
| "copy:locales": "node pontoon-to-webext", | |||
| "copy:assets": "shx cp -r src/manifest.json src/icons dist/ && svgo src/icons -o dist/icons && shx cp -r src/popup/*.html src/popup/FiraSans-Regular.* dist/popup/", | |||
There was a problem hiding this comment.
No need to copy the [unoptimized] src/icons here, since we're copying them in the next step using SVGO during optimization.
There was a problem hiding this comment.
Am I correct that this wonʼt copy the src/icons/color_bell_icon.png? Should we change that to src/icons/*.png instead?
There was a problem hiding this comment.
Yeah, not all icons are SVG
There was a problem hiding this comment.
OK, tweaked this slightly to cp -r src/manifest.json src/icons dist/ && svgo dist/icons --quiet.
That should copy all the "src/icons/*" files (PNG and SVG) into "dist/icons", and then just run svgo optimizer on all the dist/icons/*.svg files and overwrite them in place.
package.json
Outdated
| @@ -68,14 +68,14 @@ | |||
| "clean": "rm -rf dist && shx mkdir -p dist/popup", | |||
| "watch": "npm-run-all --parallel watch:*", | |||
| "copy:locales": "node pontoon-to-webext", | |||
| "copy:assets": "shx cp -r src/manifest.json src/icons dist/ && svgo src/icons -o dist/icons && shx cp -r src/popup/*.html src/popup/FiraSans-Regular.* dist/popup/", | |||
| "copy:assets": "shx cp -r src/manifest.json dist/ && svgo src/icons -o dist/icons --quiet && shx cp -r src/popup/*.html src/popup/FiraSans-Regular.* dist/popup/", | |||
There was a problem hiding this comment.
Added --quiet flag, since flooding the console w/ minimization results each time seems unnecessary.
| "copy:js": "shx cp node_modules/testpilot-metrics/testpilot-metrics.js dist/", | ||
| "bundle:js": "npm run lint:js && rollup -c --environment entry:background && rollup -c --environment entry:popup/snooze-content && rollup -c --environment entry:lib/confirm-bar", | ||
| "bundle:css": "npm run lint:sass && shx mkdir -p dist/popup && node-sass src/popup/snooze.scss > dist/popup/snooze.css", | ||
| "package": "npm run build && web-ext build -s dist -a .", | ||
| "lint": "npm-run-all --parallel lint:*", | ||
| "lint:js": "eslint --max-warnings=0 .", | ||
| "lint:sass": "sass-lint --max-warnings 0 --verbose --no-exit src/**/*.scss", |
There was a problem hiding this comment.
Removed the source glob here, since we already define the files to lint in the .sass-lint.yml config file (on line 2).
| @@ -20,7 +20,7 @@ | |||
| "no-unused-vars": "warn", | |||
| "no-var": "error", | |||
| "prefer-const": "error", | |||
| "quotes": ["error", "single"], | |||
| "quotes": ["error", "single", {"avoidEscape": true}], | |||
There was a problem hiding this comment.
Sneakily added this since I was playing w/ prettier on this repo and it was doing some escaping of single quotes in the stories/index.js:
/Users/pdehaan/dev/github/mozilla/SnoozeTabs/stories/index.js
27:12 error Strings must use singlequote quotes
33:12 error Strings must use singlequote quotes
63:12 error Strings must use singlequote quotes
69:12 error Strings must use singlequote quotes
✖ 4 problems (4 errors, 0 warnings)
.sass-lint.yml
Outdated
| no-qualifying-elements: 0 | ||
| no-vendor-prefixes: 0 | ||
| property-sort-order: 0 | ||
| shorthand-values: 0 |
| @@ -68,14 +68,14 @@ | |||
| "clean": "rm -rf dist && shx mkdir -p dist/popup", | |||
| "watch": "npm-run-all --parallel watch:*", | |||
| "copy:locales": "node pontoon-to-webext", | |||
| "copy:assets": "shx cp -r src/manifest.json src/icons dist/ && svgo src/icons -o dist/icons && shx cp -r src/popup/*.html src/popup/FiraSans-Regular.* dist/popup/", | |||
There was a problem hiding this comment.
Am I correct that this wonʼt copy the src/icons/color_bell_icon.png? Should we change that to src/icons/*.png instead?
pdehaan
force-pushed
the
tweak-linting
branch
from
b92a943
to
e33af3d
Compare
pdehaan
force-pushed
the
tweak-linting
branch
from
e33af3d
to
665b2bf
Compare
¯\_(ツ)_/¯