Fix ID in webext manifest #404
Conversation
Looks like the ID for the WebExtension in the manifest.json was left off, which means the extension was getting a generated ID. That ID didn't end in @mozilla.com, which means that the [context-fill feature][context-fill] feature wasn't enabled. This also would have caused other problems. [context-fill]: https://dxr.mozilla.org/mozilla-central/source/layout/svg/SVGContextPaint.cpp#69 Fixes bwinton#401.
| 'gecko': Object.assign({ | ||
| 'id': packageMeta.id | ||
| }, packageMeta.webextensionManifest.applications.gecko) | ||
| } | ||
| }, packageMeta.webextensionManifest); |
There was a problem hiding this comment.
Turns out that the change I made earlier that changed the order of merging these objects just ended up clobbering the applications.gecko.id assignment in the Object.merge call up there. So, simplifying things by just making a straightforward assignment
There was a problem hiding this comment.
Could we remove the id from webExtensionManifest.applications.gecko instead, if we know we want the packageMeta one?
There was a problem hiding this comment.
Problem is that there isn't an id in there already. The only property in there is update_url, and that was clobbering the merged object
There was a problem hiding this comment.
Oh, cause they don't get merged… Dang. Okay, r=me.
There was a problem hiding this comment.
Yeah, Object.assign is a dumb flat merge ugh
| 'gecko': Object.assign({ | ||
| 'id': packageMeta.id | ||
| }, packageMeta.webextensionManifest.applications.gecko) | ||
| } | ||
| }, packageMeta.webextensionManifest); |
There was a problem hiding this comment.
Oh, cause they don't get merged… Dang. Okay, r=me.
Looks like the ID for the WebExtension in the manifest.json was left
off, which means the extension was getting a generated ID.
That ID didn't end in @mozilla.com, which means that the context-fill
feature feature wasn't enabled.
This also would have caused other problems.
Fixes #401.