Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Channel parent IDs #447

Closed
Seklfreak opened this issue Sep 22, 2017 · 8 comments
Closed

Implement Channel parent IDs #447

Seklfreak opened this issue Sep 22, 2017 · 8 comments
Labels
feature Feature implementation
Milestone

Comments

@Seklfreak
Copy link
Contributor

The Discord API added a new field to the Channel object to support the newly added Channel Categories called parent_id. The change is mentioned here: https://discordapp.com/developers/docs/change-log#september-20-2017.

@Seklfreak
Copy link
Contributor Author

Pull request: #448

@Hinara
Copy link
Contributor

Hinara commented Sep 22, 2017

Need to implement the categories permissions too I suppose ^^

@Seklfreak
Copy link
Contributor Author

Category Permissions should already be possible to change using ChannelPermissionSet, Categories are just Channels. Looking at the Diff for the Discord API Docs change, I think the only interesting addition would be to make it possible to set the parent_id using a func.
The commit in question: discord/discord-api-docs@7f0b113#diff-99b76a48d014c043f2f8804f6653ed82R353

@Seklfreak
Copy link
Contributor Author

I'm not sure if we should break all previous versions by adding a parentID parameter to ChannelEdit or add a new func.

@Seklfreak Seklfreak reopened this Sep 22, 2017
@Hinara
Copy link
Contributor

Hinara commented Sep 22, 2017

I think it's better to create a ChannelEdit object like for messageEdit (Which will prevent problems with future changes as we only add fields). But the problem still the same.
@bwmarrin ?
And we need to take care of the new field permission_overwrites as they work with Category Channels if I understand correctly.
Ok didn't looked at the official docs for a while ^^' So yes apparently the only problem is about ChannelEdit.

@Seklfreak
Copy link
Contributor Author

Just tested it and was able to change the overwrites using ChannelPermissionSet just as we used to do with Text and Voice channels. Internally there is no difference between Text, Voice and Category Channels.

@Hinara
Copy link
Contributor

Hinara commented Sep 22, 2017

A bit too late I edit my post just few seconds earlier x)
Yes I wasn't understanding because if I correctly remember at a time permissions was named permissions.
So I was thinking permissionOverwrite was for Category Channels

@Seklfreak
Copy link
Contributor Author

This has been completed in #493 .

@bwmarrin bwmarrin added this to the v0.18.0 milestone Dec 27, 2017
@bwmarrin bwmarrin added the feature Feature implementation label Dec 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature implementation
Projects
None yet
Development

No branches or pull requests

3 participants