Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TH10/16 Temperature Offset #160

Closed
Dominik-1980 opened this issue Dec 3, 2020 · 12 comments
Closed

TH10/16 Temperature Offset #160

Dominik-1980 opened this issue Dec 3, 2020 · 12 comments

Comments

@Dominik-1980
Copy link

What issue do you have? Please be as thorough and explicit as possible.

Just a question, no bug.
Is it possible to adjust the degrees shown in Homekit?
My TH16 shows 2 degrees celsius less than the real temperature is...

Details of your setup.

  • Do you use Homebridge (with config-ui?) or HOOBS?

Homebridge

  • Which version of Homebridge/HOOBS do you have?

1.1.6

  • Which version of this plugin (homebridge-ewelink) do you have? Has the issue started since upgrading from a previous version?

latest

  • Which eWeLink devices do you have that are causing issues? Please include product models if applicable.

TH16

  • Do you use your main eWeLink credentials or do you use a secondary eWeLink account for Homebridge?

Main

Please paste any relevant logs below.

@bwp91
Copy link
Owner

bwp91 commented Dec 4, 2020

Hi @DrDoom666
Do you have any other TH devices? or just this one?

@Dominik-1980
Copy link
Author

Dominik-1980 commented Dec 4, 2020 via email

@bwp91
Copy link
Owner

bwp91 commented Dec 4, 2020

  • Please update to beta version 3.16.3-2, then restart Homebridge.
  • Then add this line to the config.json:
    "thOffsetTwo": "100XXXXXX",
    where 100XXXXXX is the device id of the TH10/16 device that you want to offset
  • Then restart Homebridge and see if it works

Please note I do not own a TH10/16 device myself, so am unable to test the changes I have made, meaning, there might be errors or it doesn't work properly at first.

So please let me know how you get on!

@Dominik-1980
Copy link
Author

Works great!!
Thank you!!

Is it possible to adjust other devices +1, +2, -1, -2 ?

@bwp91
Copy link
Owner

bwp91 commented Dec 4, 2020

What I implemented was a hard-coded quick solution to the sensor you mentioned in your original message.
Surely these TH devices are meant to be accurate anyway? If you’re having to offset others then it seems the sensors aren’t doing their job properly?

@bwp91
Copy link
Owner

bwp91 commented Dec 5, 2020

I will close this issue now as hopefully the fix will help the sensor that is reading 2 degrees lower than it should.
I will look into implementing a way for it to be more flexible, ie, allowing different sensors to offset by +/- different temperatures.
Keep an eye out for this on a future version :)

@bwp91 bwp91 closed this as completed Dec 5, 2020
@bwp91 bwp91 changed the title Is it possible to adjust wrong temperature? TH10/16 Temperature Offset Dec 5, 2020
@bwp91 bwp91 reopened this Dec 5, 2020
@bwp91
Copy link
Owner

bwp91 commented Dec 5, 2020

Opening this again as I found some time to try and implement something better.

@DrDoom666 please would you:

  • update to another beta, v3.16.4-0
  • restart Homebridge
  • remove the "thOffsetTwo": "100XXXXXX", line from your config
  • add this to your config, where 100####### is the device id and 2 is the offset (can be any number inc. negative)
"thTempOffset": [
  {
    "deviceId": "100#######",
    "offset": 2
  }
],
  • restart Homebridge again and test :)

For multiple devices you should use this as a template:

"thTempOffset": [
  {
    "deviceId": "100#######",
    "offset": 2
  },
  {
    "deviceId": "100#######",
    "offset": 1
  },
  {
    "deviceId": "100#######",
    "offset": -2.5
  }
],

@Dominik-1980
Copy link
Author

Great work! I will test it tomorrow and give you feedback!
Now I have to go to bed. It is late in good old germany. ;-)

@Dominik-1980
Copy link
Author

It works!! :-)

@bwp91
Copy link
Owner

bwp91 commented Dec 6, 2020

Ah i’m glad. Hope it’s helpful!

@bwp91 bwp91 added complete and removed testing labels Dec 6, 2020
@github-actions
Copy link

github-actions bot commented Dec 6, 2020

This issue has been marked as complete as I believe the original query has been fixed/answered or will not be actioned. The issue will be closed in three days. If you feel the issue requires further attention then please let me know. Thanks!

@no-response
Copy link

no-response bot commented Dec 9, 2020

This issue has been automatically closed as it was marked as complete and has had no further responses within three days. If you are still experiencing problems related to the original issue then please reply to this message and the issue will be reopened if necessary. Thank you.

@no-response no-response bot closed this as completed Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants