Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrectly failing unsupported version check #35

Closed
JohnAnthony opened this issue Jun 24, 2020 · 3 comments · Fixed by #36
Closed

Incorrectly failing unsupported version check #35

JohnAnthony opened this issue Jun 24, 2020 · 3 comments · Fixed by #36

Comments

@JohnAnthony
Copy link

It looks like the version check may be being a little overzealous, perhaps expecting a patch version where my installed version of Go reports none.

ja@vecna ~/git/galvatron/services (git)-[master] % bingo get github.com/go-bindata/go-bindata/...
Error: get command failed: found unsupported go version: go version go1.14 linux/amd64
. Requires go1.14.x
1 ja@vecna ~/git/galvatron/services (git)-[master] % go version                                                                                                                                                                                                                                                             :(
go version go1.14 linux/amd64
ja@vecna ~/git/galvatron/services (git)-[master] % head -n 5 go.mod
module rainbird.ai/galvatron

go 1.14

require (
ja@vecna ~/git/galvatron/services (git)-[master] %
@bwplotka
Copy link
Owner

Definitely.. there is even todo for this. Le's do this now (:

bwplotka added a commit that referenced this issue Jun 26, 2020
@bwplotka
Fixed Go version check.
017750b 
Fixes #35

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
@bwplotka bwplotka mentioned this issue Jun 26, 2020
Merged
bwplotka added a commit that referenced this issue Jun 26, 2020
@bwplotka
Fixed Go version check.
9c1b788 
Fixes #35

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
bwplotka added a commit that referenced this issue Jun 26, 2020
@bwplotka
Fixed Go version check.
283d223 
Fixes #35

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
bwplotka added a commit that referenced this issue Jun 26, 2020
@bwplotka
Fixed Go version check.
f96a55b 
Fixes #35

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
bwplotka added a commit that referenced this issue Jun 26, 2020
@bwplotka
Fixed Go version check. (#36)
ff616a6 
Fixes #35

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
@bwplotka
Copy link
Owner

Available in https://github.com/bwplotka/bingo/releases/tag/v0.2.3 🤗 :

@JohnAnthony
Copy link
Author

Awesome, that fixes it for me. Cheers 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed Go version check; Released v0.2.3 bwplotka/bingo
2 participants
@JohnAnthony @bwplotka