Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support build tags #46

Closed
metalmatze opened this issue Sep 14, 2020 · 4 comments · Fixed by #82
Closed

Support build tags #46

metalmatze opened this issue Sep 14, 2020 · 4 comments · Fixed by #82
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@metalmatze
Copy link

I have the problem of wanting to import a build tool that has a build tag tools.
https://github.com/observatorium/deployments/blob/f460944fe1a95ff062886c95f04a654d3c26910c/Makefile

Not sure how that is supported right now. I'll add it manually and overwrite the build command in the Makefile.

@metalmatze
Copy link
Author

I tried adding this to bingo myself and I think it requires a bit more thought.
It seems that all dependencies are written as mod files to disk and then there's essentially no other shared state where we could communicate some additional build tags from the CLI to the generated Makefile. 🤔

@bwplotka
Copy link
Owner

The only persistency is in .mod file

How I would do is that I would add flag tags to get that has package in it, and I would put -tags (or any other build flags) in comment for direct require.

Bingo uses this already for package path, but we can add build flags on top (e.g tools)

Help wanted. 🤗

@bwplotka bwplotka added the help wanted Extra attention is needed label Jan 15, 2021
@bwplotka
Copy link
Owner

cc @kakkoyun

@bwplotka bwplotka added the enhancement New feature or request label Jan 15, 2021
@bwplotka
Copy link
Owner

Another use case: Extended Hugo support: https://github.com/gohugoio/hugo#prerequisite-tools

bwplotka added a commit that referenced this issue May 12, 2021
Fixes: #46

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
bwplotka added a commit that referenced this issue May 13, 2021
Fixes: #46

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
bwplotka added a commit that referenced this issue May 13, 2021
Fixes: #46

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants