Add `links.validate.config` flag #33

saswatamcode · 2021-05-20T11:44:27Z

This PR adds in the --links.validate.config flag which allows users to pass in path to YAML config with composable regex matchers.

A sample yaml config would be,

validators:
  - regex: 'bwplotka\/mdox'
    token: '$(GITHUB_TOKEN)'
    type: "github"
  - regex: '(^http[s]?:\/\/)(www\.)?(fakelink[0-9]\.com\/)'
    type: "ignore"
  - regex: 'mycustomdomain'
    type: "roundtrip"

Here, all links are checked with default type ignore, i.e, links are not visited. If type is set to roundtrip, then links matching provided regex are visited by colly. For type github only repo name regex is taken, which then directs mdox to not visit any GitHub issue/PR link of that repo. User can also provide a token(env var substitution) to tackle GitHub API rate limiting.

Also, we don't check if a particular number is an issue or a PR since GitHub can automatically redirect such links to the correct page, for example the linkhttps://github.com/bwplotka/mdox/pull/30 is actually an issue and will be redirected. So such links can be safely skipped.

bwplotka

Amazing work. I would aim however for something more flexible, so we can add other smart "validators" WDYT? (:

bwplotka · 2021-05-21T11:02:13Z

README.md

@@ -63,6 +63,10 @@ Flags:
      --links.validate.without-address-regex=^$  
                                 If specified, all links will be validated,
                                 except those matching the given target address.
+      --links.validate.without-github-links=""  


Hm, this is great, but I wonder if we can introduce better composability here.

E.g what if we find good mechanism for understanding GH wiki links, notifications or releases?

What if someone has website X and knows that links like a/b/c will work there as long as host is ok?

I think we should allow some flexibility for users to add those, WDYT?

I would suggest something like:

--links.validate.config="<yaml content of filepath>"

(pathorcontent flag) with yaml like:

validate: validators: - regex: "(^http[s]?:\/\/)(www\.)github\.com" type: "github" # by default things are checked with `type: roundtrip`

.. so similar flow as with globs and transform yaml WDYT?

I think that would be great! It would be better to allow users to pass in yaml config and maybe have multiple validators. Will try and implement this!

bwplotka · 2021-05-21T11:04:25Z

pkg/mdformatter/linktransformer/link.go

+	Number int `json:"number"`
+}
+
+func getGitHubRegex(reponame string) (*regexp.Regexp, int, error) {


Let's make it a separate validator, totally separate file etc as this is complex. For readability it's best to isolate complexities from each other and abstract them away (:

Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>

bwplotka

Nice, Looks quite good, some nits.

bwplotka · 2021-05-27T11:39:40Z

README.md

+      --links.validate.config=""  
+                                 Path to YAML file for skipping link check, with
+                                 spec defined in
+                                 github.com/bwplotka/mdox/pkg/linktranformer.Config


Suggested change

github.com/bwplotka/mdox/pkg/linktranformer.Config

github.com/bwplotka/mdox/pkg/linktransformer.Config

bwplotka · 2021-05-27T11:40:08Z

README.md

@@ -63,6 +63,10 @@ Flags:
      --links.validate.without-address-regex=^$  


Let's kill this flag and use below one maybe?

(We can adjust flag names before first release - later it will be pain for users so let's make sure we got it right now)

Sure! Would be easier!

bwplotka · 2021-05-27T11:40:20Z

main.go

@@ -127,6 +127,7 @@ This directive runs executable with arguments and put its stderr and stdout outp
 	// TODO(bwplotka): Add cache in file?
 	linksValidateEnabled := cmd.Flag("links.validate", "If true, all links will be validated").Short('l').Bool()
 	linksValidateExceptDomains := cmd.Flag("links.validate.without-address-regex", "If specified, all links will be validated, except those matching the given target address.").Default(`^$`).Regexp()
+	linksValidateConfig := cmd.Flag("links.validate.config", "Path to YAML file for skipping link check, with spec defined in github.com/bwplotka/mdox/pkg/linktranformer.Config").Default("").String()


Suggested change

linksValidateConfig := cmd.Flag("links.validate.config", "Path to YAML file for skipping link check, with spec defined in github.com/bwplotka/mdox/pkg/linktranformer.Config").Default("").String()

linksValidateConfig := cmd.Flag("links.validate.config", "Path to YAML file for skipping link check, with spec defined in github.com/bwplotka/mdox/pkg/linktransformer.Config").Default("").String()

bwplotka · 2021-05-27T11:40:28Z

main.go

@@ -127,6 +127,7 @@ This directive runs executable with arguments and put its stderr and stdout outp
 	// TODO(bwplotka): Add cache in file?
 	linksValidateEnabled := cmd.Flag("links.validate", "If true, all links will be validated").Short('l').Bool()
 	linksValidateExceptDomains := cmd.Flag("links.validate.without-address-regex", "If specified, all links will be validated, except those matching the given target address.").Default(`^$`).Regexp()
+	linksValidateConfig := cmd.Flag("links.validate.config", "Path to YAML file for skipping link check, with spec defined in github.com/bwplotka/mdox/pkg/linktranformer.Config").Default("").String()


Can we use pathorcontent flag?

bwplotka · 2021-05-27T11:41:08Z

pkg/mdformatter/linktransformer/config.go

+type Config struct {
+	Version int
+
+	Validate struct {


Why not stright Validators field here?

I was trying to match the structure in your previous review. Will change it!

bwplotka · 2021-05-27T11:41:25Z

pkg/mdformatter/linktransformer/config.go

+
+type Validator struct {
+	_regex  *regexp.Regexp
+	_maxnum int


Suggested change

_maxnum int

_maxNum int

bwplotka · 2021-05-27T11:46:24Z

pkg/mdformatter/linktransformer/link.go

 	return v, nil
 }

 // MustNewValidator returns mdformatter.LinkTransformer that crawls all links.
-func MustNewValidator(logger log.Logger, except *regexp.Regexp, anchorDir string) mdformatter.LinkTransformer {
-	v, err := NewValidator(logger, except, anchorDir)
+func MustNewValidator(logger log.Logger, except *regexp.Regexp, linksValidateConfig string, anchorDir string) mdformatter.LinkTransformer {


I feel it would be best to get parsed Config here WDYT?

Sure! Would be better here!

bwplotka · 2021-05-27T11:48:29Z

pkg/mdformatter/linktransformer/validator.go

+}
+
+// Match link with any one of provided validators.
+func CheckValidators(dest string, v Config) bool {


Suggested change

func CheckValidators(dest string, v Config) bool {

func (v Config).GetValidatorForURL(url string) SomeValidator interface {

Let's have some interface for each validator so it's cleaner, WDYT?

bwplotka · 2021-05-27T11:49:47Z

pkg/mdformatter/linktransformer/validator.go

+}
+
+// If type is "github", change regex and add maxnum.
+func CheckGitHub(v Config) error {


Does it need to be public? What check means? You mean func (v Config) validateGH() error {

I'll try to implement this!

bwplotka · 2021-05-27T11:53:21Z

pkg/mdformatter/linktransformer/validator.go

+func getGitHubRegex(repoRe string) (*regexp.Regexp, int, error) {
+	if repoRe != "" {
+		// Get reponame from regex.
+		idx := strings.Index(repoRe, `\`)


Hm, it is bit confusing. What about either expecting named regex group? `(?P.*)

I'll try to implement this!

Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>

bwplotka

Thanks a lot! Much better (: Some thoughts. Almost perfect!

bwplotka · 2021-05-29T09:26:30Z

README.md

-      --links.validate.without-address-regex=^$  
-                                 If specified, all links will be validated,
-                                 except those matching the given target address.
+      --links.validate.config-file=<file-path>  


bwplotka · 2021-05-30T17:32:19Z

pkg/mdformatter/linktransformer/config.go

+	// Regex for type github is reponame matcher, like `bwplotka\/mdox`.
+	Regex string `yaml:"regex"`
+	// By default type is `roundtrip`. Could be `github`.
+	Type string `yaml:"type"`


let's make it a type ValidatorType string and then provide 2 consts with those expected values (: It will be easier to use, at least in code level

Sure! Currently, after inverting fixes, only one const is used(roundtrip) so, commenting the second one until it is used in future.

bwplotka · 2021-05-30T17:33:38Z

pkg/mdformatter/linktransformer/config.go

+}
+
+func ParseConfig(c []byte) (Config, error) {
+	if string(c) == "" {


This can surprise. Imagine someone will pass empty bytes by mistake and parse will just succeed. Can we do this on caller side?

bwplotka · 2021-05-30T17:35:39Z

pkg/mdformatter/linktransformer/validator.go

+func (v Config) GetValidatorForURL(url string) URLValidator {
+	u := URLValidator{Matched: false}
+	for _, val := range v.Validators {
+		if val._regex.MatchString(url) {


Let's invert. Prefer keep the complex logic with as small indent as possible. We found invert here and continue if not matched avoiding one indent. Same below.

See: https://thanos.io/tip/contributing/coding-style-guide.md/#control-structure-prefer-early-returns-and-avoid-else

Alright! Have made the same mistake in a number of places. Will rectify!

bwplotka · 2021-05-30T17:35:46Z

pkg/mdformatter/linktransformer/validator.go

+	u := URLValidator{Matched: false}
+	for _, val := range v.Validators {
+		if val._regex.MatchString(url) {
+			if val.Type == "github" {


Let's use proposed const

bwplotka · 2021-05-30T17:35:57Z

pkg/mdformatter/linktransformer/validator.go

+			if val.Type == "github" {
+				// Find rightmost index of match i.e, where regex match ends.
+				// This will be where issue/PR number starts. Split incase of section link and convert to int.
+				idx := val._regex.FindStringIndex(url)


This stores the rightmost index of the match, i.e gives the index of an issue/PR number. Will change the name!

bwplotka · 2021-05-30T17:36:35Z

pkg/mdformatter/linktransformer/validator.go

+				// If number in link does not exceed then link is valid. Otherwise will be checked by v.c.Visit.
+				if val._maxNum >= num && err == nil {
+					u.Matched = true
+					return u


Why return u if when this block ends also return u?

I seem to have missed this. Will remove!

bwplotka · 2021-05-30T17:52:38Z

pkg/mdformatter/linktransformer/validator.go

+	return u
+}
+
+// If type is "github", change regex and add maxnum.


Comments should always start with the function name.

bwplotka · 2021-05-30T17:52:48Z

pkg/mdformatter/linktransformer/validator.go

+// If type is "github", change regex and add maxnum.
+func (v Config) validateGH() error {
+	for i := range v.Validators {
+		if v.Validators[i].Type == "github" {


ditto - invert fo readability

bwplotka · 2021-05-30T17:54:22Z

pkg/mdformatter/linktransformer/validator.go

+
+// Get GitHub pulls/issues regex from repo name.
+func getGitHubRegex(repoRe string) (*regexp.Regexp, int, error) {
+	if repoRe != "" {


ditto and please remember about this rule. If you invert this and improve readability a lot.

Also having one big IF at the beginning is a code smell. Why invoking this function in the first place if repoRe is empty? 🤔

Sure! Will keep this in mind in future PRs.

Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>

bwplotka

Some comments during our 1:1, great job so far!

bwplotka · 2021-06-01T10:37:53Z

pkg/mdformatter/linktransformer/config.go

+	"gopkg.in/yaml.v3"
+)
+
+const roundtrip ValidatorType = "roundtrip"


It's common to put this just below the ValidatorType definition. Let's also group those into one const ( ).

Suggested change

const roundtrip ValidatorType = "roundtrip"

const roundtripValidator ValidatorType = "roundtrip"

pkg/mdformatter/linktransformer/config.go

bwplotka · 2021-06-01T10:39:27Z

pkg/mdformatter/linktransformer/link.go

+	err = v.validateConfig.validateGH()
+	if err != nil {
+		return nil, err
+	}


Suggested change

err = v.validateConfig.validateGH()

if err != nil {

return nil, err

}

return v.validateConfig.validateGH()

bwplotka · 2021-06-01T10:40:02Z

pkg/mdformatter/linktransformer/validator.go

+		if !val._regex.MatchString(url) {
+			continue
+		}
+		if val.Type == roundtrip {


Let's use switch since we want to have other validators soon

Explicit might be better

bwplotka · 2021-06-01T10:40:49Z

pkg/mdformatter/linktransformer/validator.go

+}
+
+// validateGH changes regex and adds maxNum, if type is "github".
+func (v Config) validateGH() error {


Can we do this during parsing? (It's tied to parsing - we don't need to it anytime else)

bwplotka · 2021-06-01T10:41:42Z

pkg/mdformatter/linktransformer/validator.go

+// validateGH changes regex and adds maxNum, if type is "github".
+func (v Config) validateGH() error {
+	for i := range v.Validators {
+		if v.Validators[i].Type == roundtrip {


This is where we can do explicit switch as I mentioned in Parse because we want to error out if user specifies something unknown

bwplotka · 2021-06-01T10:47:38Z

pkg/extflag/pathorcontent.go

+)
+
+// PathOrContent is a flag type that defines two flags to fetch bytes. Either from file (*-file flag) or content (* flag).
+type PathOrContent struct {


Can we add env substitution here, and then we can think about proposing this upstream.

So the idea would be to add env substitution using e.g Kubernetes format, which is $(...) and document it.

e.g our config could be Token: $(GITHUB_TOKEN)

Then we can upstream it e.g through this: efficientgo/tools#9

bwplotka · 2021-06-01T11:00:26Z

pkg/mdformatter/linktransformer/validator.go

+}
+
+// GetValidatorForURL matches link with any one of provided validators.
+func (v Config) GetValidatorForURL(url string) URLValidator {


We need to work on different abstrations here...

What about something else:

type Validator interface { IsValid(URL string) (bool, error) }

Type == github, where we can have githubValidator struct, which does gh check

Type == rt rtValidator, which does normal look up

Type == static/ignore which is always true?

Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>

bwplotka

That looks solid to me (:

bwplotka · 2021-06-03T12:35:17Z

pkg/extflag/pathorcontent.go

+}
+
+// RegisterPathOrContent registers PathOrContent flag in kingpinCmdClause.
+func RegisterPathOrContent(cmd FlagClause, flagName string, help string, required bool, envSubstitution bool) *PathOrContent {


Time for variadic options here (:

Suggested change

func RegisterPathOrContent(cmd FlagClause, flagName string, help string, required bool, envSubstitution bool) *PathOrContent {

func RegisterPathOrContent(cmd FlagClause, flagName string, help string, opts ...Option) *PathOrContent {

bwplotka · 2021-06-03T12:37:14Z

pkg/extflag/pathorcontent.go

+// substituteEnvVars returns content of YAML file with substituted environment variables.
+// Will be substituted with empty string if env var isn't set.
+// Follows K8s convention, i.e $(...), as mentioned here https://kubernetes.io/docs/tasks/inject-data-application/define-interdependent-environment-variables/.
+func substituteEnvVars(content string) []byte {


Let's take in bytes if we want to split out bytes (consistency)

Can we reuse exsiting code? https://github.com/thanos-io/thanos/blob/7d118f416be98cf502b9b5e0df4e98b37478f3f3/pkg/reloader/reloader.go#L419

Alright! Will try to reuse code from here!

Have taken existing code but used os.Getenv instead of os.LookupEnv since Token here is optional and don't want to error out if variable is unset. 🙂

Why we don't want to error out? I think that is a correct behaviour

The GITHUB_TOKEN variable is only expected to be set in CI runners so that authenticated API calls are made and it's not rate limited(Same IP across macos runners problem). But if user decides not to set the token i.e, isn't getting rate limited and doesn't need to make auth'd requests then there shouldn't be any error I think. So should I put the error back in?

But if user decides not to set the token i.e, isn't getting rate limited and doesn't need to make auth'd requests then there shouldn't be any error I think.

If user decided not to set this token, why she/he would add this to yaml as $(....) construct?

If they wanted to run CI job locally but then they can have a make-docs-local command as well. I see what you mean, I'll add error back in! 🙂

explicit configuration is better than surprising ones

Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>

bwplotka

Thanks a lot! Super close to merge

bwplotka · 2021-06-03T15:47:51Z

pkg/extflag/pathorcontent.go

+}
+
+// WithRequired allows you to override default envSubstitution option.
+func WithEnvSubstitution(e bool) Option {


Suggested change

func WithEnvSubstitution(e bool) Option {

func WithEnvSubstitution() Option {

bwplotka · 2021-06-03T15:47:58Z

pkg/extflag/pathorcontent.go

+}
+
+// WithRequired allows you to override default required option.
+func WithRequired(r bool) Option {


Suggested change

func WithRequired(r bool) Option {

func WithRequired() Option {

we don't need to expose both bools, as we have by default false, so we need to have just method for true, right?

Yes. Will change this!

bwplotka · 2021-06-03T15:50:20Z

pkg/mdformatter/linktransformer/validator.go

+}
+
+// RoundTripValidator.IsValid returns false if url matches, to ensure it is visited by colly.
+func (v RoundTripValidator) IsValid(URL string) (bool, error) {


This still needs some love 🙈

"RountTripValidator says URL is invalid" - that does not sounds like this would mean it will be check by colly. I would rather put colly logic directly here into this method, no?

Alright, will put this logic directly! 🙂

bwplotka · 2021-06-03T15:50:43Z

pkg/mdformatter/linktransformer/validator.go

+			if !val.rtValidator._regex.MatchString(URL) {
+				continue
+			}
+			u = val.rtValidator


We need u variable, we can just return, no?

Sure! I missed this, will rectify!

pkg/mdformatter/linktransformer/validator.go

bwplotka · 2021-06-03T15:52:25Z

pkg/mdformatter/linktransformer/validator.go

+		}
+	}
+	// By default all links are ignored.
+	u = IgnoreValidator{}


Hm... I don't think, I think we want to round trip rest?

Okay, I might've misunderstood earlier. Will change!

Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>

bwplotka

Thanks! LGTM (: Two issues, but it's ok to fix in later PRs 💪🏽

bwplotka · 2021-06-05T13:24:44Z

pkg/mdformatter/linktransformer/validator.go

+	r.rMu.Lock()
+	defer r.rMu.Unlock()
+	// We need to check again here to avoid race.
+	if _, ok := r.remoteLinks[k.dest]; ok {


This is some sort of "caching" that we can use on TOP of validators, so other validators can leverage it no? It's ok to think about it later PRs (:

bwplotka · 2021-06-05T13:25:27Z

pkg/mdformatter/linktransformer/validator.go

+			}
+			return val.igValidator
+		default:
+			panic("unexpected validator type")


Suggested change

panic("unexpected validator type")

panic(fmt.Sprintf("unexpected validator type %v", val.Type))

saswatamcode requested a review from bwplotka May 20, 2021 11:44

saswatamcode self-assigned this May 20, 2021

saswatamcode force-pushed the github-links branch 2 times, most recently from 73c1990 to 27376ec Compare May 20, 2021 15:22

bwplotka requested changes May 21, 2021

View reviewed changes

saswatamcode added 3 commits May 22, 2021 11:07

Add GitHub link skip flag

2a7a529

Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>

Add StatusCode checks

2cfb2e9

Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>

Add links.validate.config flag

88790de

Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>

saswatamcode force-pushed the github-links branch from 51ff48d to 88790de Compare May 27, 2021 06:08

saswatamcode changed the title ~~Add GitHub repo link skip flag~~ Add links.validate.config flag May 27, 2021

saswatamcode requested a review from bwplotka May 27, 2021 06:17

bwplotka reviewed May 27, 2021

View reviewed changes

Implement suggested changes

412bcbd

Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>

saswatamcode requested a review from bwplotka May 28, 2021 04:38

bwplotka reviewed May 30, 2021

View reviewed changes

Reduce code smell

0e2b12a

Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>

saswatamcode requested a review from bwplotka May 31, 2021 04:17

saswatamcode force-pushed the github-links branch from af2c1ce to 246930a Compare May 31, 2021 08:16

Add github token support

c46b6e4

Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>

saswatamcode force-pushed the github-links branch from 246930a to c46b6e4 Compare June 1, 2021 09:59

bwplotka reviewed Jun 1, 2021

View reviewed changes

bwplotka mentioned this pull request Jun 1, 2021

Proposal: Environment Variables Substitution for PathOrContent flag. thanos-io/thanos#4293

Closed

Add env substitution

7536052

Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>

saswatamcode requested a review from bwplotka June 3, 2021 11:11

bwplotka reviewed Jun 3, 2021

View reviewed changes

saswatamcode force-pushed the github-links branch from e5634b3 to 98e791a Compare June 3, 2021 13:50

saswatamcode requested a review from bwplotka June 3, 2021 13:53

Add abstractions for validator

3282c03

Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>

saswatamcode force-pushed the github-links branch from 98e791a to 3282c03 Compare June 3, 2021 14:31

bwplotka reviewed Jun 3, 2021

View reviewed changes

saswatamcode requested a review from bwplotka June 4, 2021 12:45

saswatamcode force-pushed the github-links branch from a9b740a to d3d8606 Compare June 4, 2021 12:47

Implement suggestions

d1c885d

Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>

saswatamcode force-pushed the github-links branch from d3d8606 to d1c885d Compare June 4, 2021 12:48

bwplotka approved these changes Jun 5, 2021

View reviewed changes

bwplotka merged commit 019c82f into bwplotka:main Jun 5, 2021

	github.com/bwplotka/mdox/pkg/linktranformer.Config
	github.com/bwplotka/mdox/pkg/linktransformer.Config

		@@ -63,6 +63,10 @@ Flags:
		--links.validate.without-address-regex=^$

	linksValidateConfig := cmd.Flag("links.validate.config", "Path to YAML file for skipping link check, with spec defined in github.com/bwplotka/mdox/pkg/linktranformer.Config").Default("").String()
	linksValidateConfig := cmd.Flag("links.validate.config", "Path to YAML file for skipping link check, with spec defined in github.com/bwplotka/mdox/pkg/linktransformer.Config").Default("").String()

	func CheckValidators(dest string, v Config) bool {
	func (v Config).GetValidatorForURL(url string) SomeValidator interface {

	const roundtrip ValidatorType = "roundtrip"
	const roundtripValidator ValidatorType = "roundtrip"

	func RegisterPathOrContent(cmd FlagClause, flagName string, help string, required bool, envSubstitution bool) *PathOrContent {
	func RegisterPathOrContent(cmd FlagClause, flagName string, help string, opts ...Option) *PathOrContent {

	func WithEnvSubstitution(e bool) Option {
	func WithEnvSubstitution() Option {

	func WithRequired(r bool) Option {
	func WithRequired() Option {

	panic("unexpected validator type")
	panic(fmt.Sprintf("unexpected validator type %v", val.Type))

Add links.validate.config flag #33

Add links.validate.config flag #33

Conversation

saswatamcode commented May 20, 2021 • edited

bwplotka left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bwplotka left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bwplotka left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bwplotka left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bwplotka left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bwplotka Jun 3, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bwplotka Jun 3, 2021 • edited

Choose a reason for hiding this comment

bwplotka left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Add `links.validate.config` flag #33

Add `links.validate.config` flag #33

saswatamcode commented May 20, 2021 •

edited

bwplotka Jun 3, 2021 •

edited

bwplotka Jun 3, 2021 •

edited