HSL color integration #1028
Merged
HSL color integration #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, will take a look |
|
Hello bwssytems, did you had the time to take a look? The HSL type looks good and I use this feature too. |
|
This looks great! Thanks for adding and contributing. Will put in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several device types linked through Openhab take an HSL/HSB value in their color setting. This code allows Ha-bridge to convert color instructions to the HSB format for passing over to Openhab and allowing openhab to handle the device-specific details from there.
I have tested this with the tplinksmarthome and wifileds bindings in Openhab. I suspect it works with many other Openhab bindings.