#49 replace switches with maps

bwsw · Aug 3, 2017 · 5cd950a · 5cd950a
1 parent 7fcdba0
commit 5cd950a
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 29 deletions.
diff --git a/src/app/snapshot/recurring-snapshots/policy-list/policy-view-builder.service.ts b/src/app/snapshot/recurring-snapshots/policy-list/policy-view-builder.service.ts
@@ -92,23 +92,14 @@ export class PolicyViewBuilderService {
   }
 
   private getTimeToken(policy: Policy<TimePolicy>): string {
-    if (policy.type === PolicyType.Hourly) {
-      return 'POLICY_HOURLY_TIME';
-    }
-
-    if (policy.type === PolicyType.Daily) {
-      return 'POLICY_DAILY_TIME';
-    }
-
-    if (policy.type === PolicyType.Weekly) {
-      return 'POLICY_WEEKLY_TIME';
-    }
-
-    if (policy.type === PolicyType.Monthly) {
-      return 'POLICY_MONTHLY_TIME';
-    }
-
-    return '';
+    const timeTokens = {
+      [PolicyType.Hourly]: 'POLICY_HOURLY_TIME',
+      [PolicyType.Daily]: 'POLICY_DAILY_TIME',
+      [PolicyType.Weekly]: 'POLICY_WEEKLY_TIME',
+      [PolicyType.Monthly]: 'POLICY_MONTHLY_TIME'
+    };
+
+    return timeTokens[policy.type];
   }
 
   private getTimeZone(policy: Policy<TimePolicy>): string {

diff --git a/src/app/snapshot/recurring-snapshots/snapshot-policy.service.ts b/src/app/snapshot/recurring-snapshots/snapshot-policy.service.ts
@@ -78,18 +78,14 @@ export class SnapshotPolicyService extends BaseBackendService<SnapshotPolicy> {
   }
 
   private transformPolicyTypeToString(type: PolicyType): string {
-    switch (type) {
-      case PolicyType.Hourly:
-        return 'hourly';
-      case PolicyType.Daily:
-        return 'daily';
-      case PolicyType.Weekly:
-        return 'weekly';
-      case PolicyType.Monthly:
-        return 'monthly';
-      default:
-        throw new Error('Incorrect policy mode');
-    }
+    const policyTypes = {
+      [PolicyType.Hourly]: 'hourly',
+      [PolicyType.Daily]: 'daily',
+      [PolicyType.Weekly]: 'weekly',
+      [PolicyType.Monthly]: 'monthly'
+    };
+
+    return policyTypes[type];
   }
 
   private transformTimePolicyToSchedule(policy: Policy<TimePolicy>): string {