Skip to content
This repository has been archived by the owner on Mar 25, 2023. It is now read-only.

Disable select button for Installation source and SO in VM creation if no elements in the list #1155

Closed
tamazlykar opened this issue Jul 14, 2018 · 8 comments

Comments

@tamazlykar
Copy link
Collaborator

tamazlykar commented Jul 14, 2018

Steps to reproduce

  1. Make sure that you do not have any ISOs (you can use a simulator)
  2. Open VM creation dialog
  3. Open the Installation source selection dialog
  4. Go to ISO tab
  5. Press select button

Actual result

Select button exists and after it was pressed an error appears at dialog window but Installation source shows previous selection. I think the same problem will be if there are no templates, but there will be ISO.

Expected result

I think we should hide button (Service offering dialog hide the Select button if there is no SO in tab) or disable, this needs to discuss with PO. If we do this then an error will not be shown.

Environment


Browser:
- [ ] Chrome version XX
- [ ] Firefox version XX
- [ ] Safari version XX
- [ ] Opera version XX
- [ ] IE version XX
- [ ] Edge version XX

Others:

Connected feature ID

vm_creation_installsource

Screenshots

Initial form state
screenshot from 2018-07-14 16-35-44
Instalation source dialog with no ISOs and the enabled selection button
screenshot from 2018-07-14 16-35-55
An error that occurs
screenshot from 2018-07-14 16-36-05
Other behavior on a similar situation in the service offering dialog
screenshot from 2018-07-14 16-36-14

@tamazlykar tamazlykar added bug discussion issues to be discussed labels Jul 14, 2018
@tamazlykar
Copy link
Collaborator Author

@zolotyx, please see the code. Do you see any solution to this problem without completely rewriting the components?

@elenaustyugova
Copy link
Collaborator

@tamazlykar discussed with PO: Select button should be disabled if no elements in the list

  • disable the button (Case of ISO Installation source)
  • show disabled button (Case of Service offering)

@elenaustyugova elenaustyugova added severity: major and removed discussion issues to be discussed labels Jul 16, 2018
@elenaustyugova elenaustyugova changed the title Active selection button in the absence of a template or ISO Disable select button for Installation source and SO in VM creation Jul 16, 2018
@elenaustyugova elenaustyugova changed the title Disable select button for Installation source and SO in VM creation Disable select button for Installation source and SO in VM creation if no elements in the list Jul 16, 2018
@elenaustyugova elenaustyugova added this to the Release 1.410.21 milestone Jul 16, 2018
@elenaustyugova
Copy link
Collaborator

Includes #1145

@tamazlykar
Copy link
Collaborator Author

Regression:
vm_creation_installsource

@tamazlykar tamazlykar assigned Nadya913 and unassigned tamazlykar Aug 14, 2018
@chewlite chewlite assigned chewlite and unassigned Nadya913 Aug 15, 2018
@chewlite
Copy link
Collaborator

An error "No templates available" still occurs

Tested on simulator

Steps:

  1. Open VM creation dialog
  2. Open the Installation source selection dialog
  3. Go to ISO tab (tab should be empty)
  4. Press Cancel button

Actual result:
42723505-12e9d63c-8789-11e8-915d-822b6b3eaa22

Expected result:
No error

@chewlite chewlite assigned tamazlykar and unassigned chewlite Aug 15, 2018
@tamazlykar
Copy link
Collaborator Author

Please check that templates displays as before and as expected and filter works right.

@tamazlykar tamazlykar assigned Nadya913 and unassigned tamazlykar Aug 16, 2018
@chewlite chewlite assigned chewlite and unassigned Nadya913 Aug 16, 2018
@chewlite
Copy link
Collaborator

chewlite commented Aug 16, 2018

vm_creation_installsource_search

Steps:

  1. Fill the search field with a value
  2. Select (fully or partially) value in the search field (with the cursor/the keyboard)

Actual:
Dialog closes and for installation source saves "OS template: undefined"
2018-08-16 16-17-23
When open Installation source dialog again:
2018-08-16 16-16-20
Expected:
Dialog stays open, value in the search field selected successfully

@chewlite chewlite assigned tamazlykar and unassigned chewlite Aug 17, 2018
@tamazlykar tamazlykar removed their assignment Aug 20, 2018
@chewlite
Copy link
Collaborator

@tamazlykar

Tested on 1176

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants