Skip to content

Commit

Permalink
CSEN-88 After merge fix
Browse files Browse the repository at this point in the history
  • Loading branch information
MedvedevBW committed Feb 6, 2018
1 parent 262c154 commit b8a6dce
Show file tree
Hide file tree
Showing 9 changed files with 17 additions and 26 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,7 @@ class AccountDaoTestSuite extends FlatSpec with TestData {
}

"find" should "handle child of AccountFindRequest" in {
val accountId = UUID.randomUUID()
val userId = UUID.randomUUID()
val expectedAccountList = List(Account(accountId, List(User(userId, accountId))))
val expectedAccountList = List(testAccount)

class TestAccountFindRequest extends AccountFindRequest

Expand All @@ -113,7 +111,7 @@ class AccountDaoTestSuite extends FlatSpec with TestData {
val executor = new Executor(executorSettings, clientCreator){
override def executeRequest(request: ApacheCloudStackRequest): String = {
assert(childRequest.getRequest == request)
Response.getAccountResponseJson(accountId.toString, userId.toString)
Response.getAccountResponseJson(testAccount)
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,7 @@ import br.com.autonomiccs.apacheCloudStack.exceptions.ApacheCloudStackClientRequ
import com.bwsw.cloudstack.entities.Executor
import com.bwsw.cloudstack.entities.requests.tag.types.UserTagType
import com.bwsw.cloudstack.entities.requests.tag.{TagCreateRequest, TagFindRequest}
import com.bwsw.cloudstack.entities.TestConstants.ParameterValues.DUMMY_VALUE
import com.bwsw.cloudstack.entities.responses.tag.Tag
import com.bwsw.cloudstack.entities.responses.Tag
import org.scalatest.FlatSpec

class TagDaoTestSuite extends FlatSpec with TestData {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,7 @@ class UserDaoTestSuite extends FlatSpec with TestData {
}

"find" should "handle child of UserFindRequest" in {
val userId = UUID.randomUUID()
val accountId = UUID.randomUUID()
val expectedUserList = List(User(userId, accountId))
val expectedUserList = List(testUser)

class TestUserFindRequest extends UserFindRequest

Expand All @@ -110,7 +108,7 @@ class UserDaoTestSuite extends FlatSpec with TestData {
val executor = new Executor(executorSettings, clientCreator){
override def executeRequest(request: ApacheCloudStackRequest): String = {
assert(findUserRequest.getRequest == request)
Response.getUserResponseJson(userId.toString, accountId.toString)
Response.getUserResponseJson(testUser)
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -101,10 +101,7 @@ class VirtualMachineDaoTestSuite extends FlatSpec with TestData {
}

"find" should "handle child of VmFindRequest" in {
val vmId = UUID.randomUUID()
val accountName = "test"
val domainId = UUID.randomUUID()
val expectedVmList = List(VirtualMachine(vmId, accountName, domainId))
val expectedVmList = List(testVm)

class TestVmFindRequest extends VmFindRequest

Expand All @@ -113,7 +110,7 @@ class VirtualMachineDaoTestSuite extends FlatSpec with TestData {
val executor = new Executor(executorSettings, clientCreator){
override def executeRequest(request: ApacheCloudStackRequest): String = {
assert(vmFindRequest.getRequest == request)
Response.getVmResponseJson(vmId.toString, accountName, domainId.toString)
Response.getVmResponseJson(testVm)
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class DomainCreateRequestTestSuite extends FlatSpec {
it should "create a request with predefined and specified (via constructor) parameters" in {
val request = new DomainCreateRequest(domainName)

assert(request.request.getParameters.asScala.toSet == defaultParameters)
assert(request.request.getCommand == Commands.CREATE_DOMAIN)
assert(request.getRequest.getParameters.asScala.toSet == defaultParameters)
assert(request.getRequest.getCommand == Commands.CREATE_DOMAIN)
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class DomainFindRequestTestSuite extends FlatSpec {
it should "create a request with predefined parameters" in {
val request = new DomainFindRequest

assert(request.request.getParameters.asScala.toSet == defaultParameters)
assert(request.request.getCommand == Commands.LIST_DOMAINS)
assert(request.getRequest.getParameters.asScala.toSet == defaultParameters)
assert(request.getRequest.getCommand == Commands.LIST_DOMAINS)
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class ServiceOfferingFindRequestTestSuite extends FlatSpec {
it should "create a request with predefined parameters" in {
val request = new ServiceOfferingFindRequest

assert(request.request.getParameters.asScala.toSet == defaultParameters)
assert(request.request.getCommand == Commands.LIST_SERVICE_OFFERINGS)
assert(request.getRequest.getParameters.asScala.toSet == defaultParameters)
assert(request.getRequest.getCommand == Commands.LIST_SERVICE_OFFERINGS)
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ class TemplateFindRequestTestSuite extends FlatSpec {
it should "create a request with predefined and specified (via constructor) parameters" in {
val request = new TemplateFindRequest(All)

assert(request.request.getParameters.asScala.toSet == defaultParameters)
assert(request.request.getCommand == Commands.LIST_TEMPLATES)
assert(request.getRequest.getParameters.asScala.toSet == defaultParameters)
assert(request.getRequest.getCommand == Commands.LIST_TEMPLATES)
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ class ZoneFindRequestTestSuite extends FlatSpec {
it should "create a request with predefined parameters" in {
val request = new ZoneFindRequest

assert(request.request.getParameters.asScala.toSet == defaultParameters)
assert(request.request.getCommand == Commands.LIST_ZONES)
assert(request.getRequest.getParameters.asScala.toSet == defaultParameters)
assert(request.getRequest.getCommand == Commands.LIST_ZONES)
}


Expand All @@ -44,6 +44,6 @@ class ZoneFindRequestTestSuite extends FlatSpec {
val expectedParameters = defaultParameters ++ Set(new ApacheCloudStackApiCommandParameter(ParameterKeys.AVAILABLE, isAvailable))
val request = new ZoneFindRequest

assert(request.withAvailableFlag(isAvailable).request.getParameters.asScala.toSet == expectedParameters)
assert(request.withAvailableFlag(isAvailable).getRequest.getParameters.asScala.toSet == expectedParameters)
}
}

0 comments on commit b8a6dce

Please sign in to comment.