chore: makes command make run reliable #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make run may fail in some cases where mysql startup time takes a little longer time than usual. depends_on directive guarantees only that mysql container will be started first and web will start second and sometimes when web is trying to connect to mysql, mysql is still not ready for connections. So health-check will first wait for mysql up and ready for connections and only then web container will launched.
bxcodec
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make run may fail in some cases where mysql startup time takes a little longer time than usual.
depends_on directive guarantees only that mysql container will be started first and web will start second and sometimes when web is trying to connect to mysql, mysql is still not ready for connections.
So health-check will first wait for mysql up and ready for connections and only then web container will launched.
btw, thanks for the great example!