Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From NumPy 1.24.0 np.float is deprecated #90

Merged
merged 2 commits into from
Jan 25, 2023
Merged

From NumPy 1.24.0 np.float is deprecated #90

merged 2 commits into from
Jan 25, 2023

Conversation

lldelisle
Copy link
Collaborator

@lldelisle lldelisle commented Jan 24, 2023

I removed them to make bx-python compatible with last version of numpy but this drop support for numpy <1.20. I don't know which file I should modify.

@nsoranzo nsoranzo changed the title From Numpy 0.24 np.float is deprecated From NumPy 1.24.0 np.float is deprecated Jan 24, 2023
@lldelisle
Copy link
Collaborator Author

@nsoranzo do you know where should I restrict numpy version?

@nsoranzo
Copy link
Collaborator

I removed them to make bx-python compatible with last version of numpy but this drop support for numpy <0.20

Are you sure this breaks compatibility with older numpy? And, do you mean numpy <1.20 perhaps?

@lldelisle
Copy link
Collaborator Author

Yes exactly
The new code requires numpy>=1.20

@nsoranzo
Copy link
Collaborator

It does seem to work in my hands as far back as numpy 1.14.5 , what error do you see?

@lldelisle
Copy link
Collaborator Author

Then perfect. I thought these changes would break... One deploy was too long, is it ok to merge like this?

@nsoranzo nsoranzo merged commit edfaae1 into main Jan 25, 2023
@nsoranzo nsoranzo deleted the fix_numpy branch January 25, 2023 13:06
@nsoranzo
Copy link
Collaborator

Yes, thanks, will fix the deploy separately.

@nsoranzo
Copy link
Collaborator

Yes, thanks, will fix the deploy separately.

Fixed in 6f7e5ca . Let me know if we should do a release.

@lldelisle
Copy link
Collaborator Author

For me it is ok. Let see if people need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants