Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct compile error on ESP32 #23

Closed
wants to merge 1 commit into from
Closed

Conversation

ciband
Copy link
Contributor

@ciband ciband commented Apr 25, 2018

Added additional case to cover ESP32

Added additional case to cover ESP32
@ciband
Copy link
Contributor Author

ciband commented Apr 25, 2018

Thank you for making this library. Our project is benefiting from using it.

The current release will not compile for us so we are looking forward to the next release based off of this develop branch.

Thank you.

@bxparks
Copy link
Owner

bxparks commented Apr 25, 2018

Hi Chris,

Thanks for the PR.
I'd be happy to support ESP32 officially after I get one of those boards. In the meantime, I'll download the Arduino core for ESP32 and at least verify that your PR compiles.

Have you verified that your PR passes the unit tests for AUnit itself on the ESP32?

  • tests/AUnitTest
  • tests/FilterTest
  • tests/SetupAndTeardownTest

(Can you do another git pull on develop before running the tests? Looks like I had a commit that I had forgotten to push.)

@ciband
Copy link
Contributor Author

ciband commented Apr 25, 2018

I haven't verified the AUnit tests. My actual ESP32 board is in transit. I've been working through platformio until it gets here.

Once I get my board I will run through the tests.

Thanks for the response.

@ciband
Copy link
Contributor Author

ciband commented May 1, 2018

Fixed in #26

@ciband ciband closed this May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants