-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge 2.2.0 into master #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not just len() > 1
…ytes, decreases full DB by 300-400 bytes
…dBrokers.h, towards broker unification
…mpat.h into zoneinfo/
…e that year must be roughly within ZoneContext (startYear, untilYear)
… to '<=' The year interval used by AceTimeTools/bufestimator.py is now slighlty larger (e.g. `[1950,2090]`) than the year interval used in the validation tests (usually `[2000,2100)`). (The upper limit of 2090 was determined by bufestimator.py to the be maximum terminal year, so anything above causes no change to the buffer size, hence equivalent to the year 2100 used by the validation tests.) Sometimes the observed transition buffer size is slightly smaller than the estimated buffer size.
Also do some clean up, because I think a number of bugs that this file was trying to overcome has been fixed in the intervening years between 2018 and 2023.
The `const char* letter` was being initialized with a `{0}` because the previous code defined `letter` as `char letter[2]`, and the test didn't get updated. Weird thing is that both g++ and clang++ on Linux produced no errors, nor did all the other Arduino compilers. It was only the ARM g++ for the SAMD21 that complained about this.
…ars on microcontrollers On desktop (using EpoxyDuino), check the full 8000 year interval [2000, 10000). On slow microcontrollers, check only 100 years [2000, 2100).
Seeed XIAO seems to need a 1 or 2 delay after flashing before the serial port monitor can be connected. On the other hand, the ESP8266 must have no delay, otherwise the output gets lost. So use a flag for XIAO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TimeZone::forMinutes()
fromuint8_t
touint16_t
.TimeZone
effectively immutable, by removingsetStdOffset()
and
setDstOffset()
methods.TimeZone
object usingTimeZone::forTimeOffset(std, dst)
and overwrite the old one.zoneino/compat.h
to clobber the broken definitionof
FPSTR()
in Seeeduino 1.8.3.Rule.LETTER
.ZoneContext.letters
array, notjust
LETTER
which are only a single character.BasicZoneProcessor
by ~200 bytes when 1-2 zones areused. But flash remains the same when the full TZ database is
used.
ExtendedZoneProcessor
for 1-2 zones. But decreasesflash usage by ~300 bytes when the full TZ database is used.
simplifies the complicated code surrounding LETTER that was difficult
to understand and maintain.
basic::ZoneRule.deltaCode
,basic::ZoneEra.deltaCode
, andbasic::ZoneEra.offsetCode
to beidentical their counterparts in
extended::ZoneXxx
.BasicBrokers.h
andExtendedBrokers.h
into justBrokers.h
.ace_time/internal/testing/tzonedb[x]
database filesto
ace_time/tzonedb[x]
.ace_time/zonedb[x]
database files toace_time/zonedb[x]
.namespaces of these files are unchanged.
ace_time/internal/Zone*.h
files into newsrc/zoneinfo/
directory. These are the classes that describe the
*zonedb*
databases.
ZonedDateTime::offsetDateTime()
OffsetDateTime
inside theZonedDateTime
.ZonedDateTime::localDateTime()
.ExtendedZoneProcessor
to work over all years[0,10000)
even with truncated zonedb (e.g.
[2000,2100)
).[2000,2100)
.