Use Babel for currency formating; fix and improve tests #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
PetrDlouhy
commented
Apr 20, 2016
PetrDlouhy
commented
- This PR fixes bug Setting locale can have unanticipated side effects #19 by using babel (http://babel.pocoo.org) to format currency strings.
- It also fixes problem with replacing ",00" to ",-" which does not work for english comma separated thousands. Now it is applied only with czech locale.
- The compatibility with Python 2 is restored
- Tests are improved to test also contents of the generated PDF files and generating with 'en' locale.
Closed
|
@creckx This PR contains very important fixes of InvoiceGenerator. Can you please pull? |
|
@creckx Could you please pull and make new release of PyPI package? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.