This repository has been archived by the owner on Sep 24, 2020. It is now read-only.
Add support for updating existing records using PUT #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that PUT isn't documented in the DNSMadeEasy 1.2 documentation but I have used it in production systems for a couple months without issue. It *is* in their 2.0 API.
| @@ -100,5 +100,19 @@ public function delete($domain, $recordId) | |||
|
|
|||
| return $apiResponse; | |||
| } | |||
|
|
|||
| public function update($domain, $recordId, $record) | |||
There was a problem hiding this comment.
looks great! would just suggest you document this function similar to how the others are.
|
There we go. Thanks for this library, by the way, it's saved me a ton of work. :) |
byalextran
pushed a commit
that referenced
this pull request
Sep 22, 2012
Add support for updating existing records using PUT
|
glad it helped you and thanks for the contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that PUT isn't documented in the DNSMadeEasy 1.2
documentation but I have used it in production systems for a couple
months without issue. It is in their 2.0 API.