Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the progress bar without disabling other pretty things #206

Closed
eldipa opened this issue Oct 31, 2021 · 0 comments · Fixed by #207
Closed

Disable the progress bar without disabling other pretty things #206

eldipa opened this issue Oct 31, 2021 · 0 comments · Fixed by #207
Labels
enhancement something nice to have but it is not neither critical nor urgent
Milestone

Comments

@eldipa
Copy link
Collaborator

eldipa commented Oct 31, 2021

Describe the feature you'd like
When running byexample as a pre-commit hook as proposed in #202 , the output looks almost perfect:

**********************************************************************
File "Foo.md", line 4
Failed example:
    1+2
Expected:
3a
Got:
3

File Foo.md, 3/3 test ran in 2.02 seconds
[FAIL] Pass: 2 Fail: 1 Skip: 0

File README.md, 3/3 test ran in 2.01 seconds
[PASS] Pass: 3 Fail: 0 Skip: 0
README.md: 100% 3/3 [00:02<00:00,  1.49it/s, line 5]

The last line however looks weird. The README.md: 100% 3/3 [00:02<00:00, 1.49it/s, line 5] is just an artifact of the progress bar of byexample.

This progress bar is not shown by pre-commit because it executes byexample in background and only prints its output at the end.

For this reason byexample should have a way to disable the progress bar. In fact it has one with --pretty none but that also disables the colors.

@eldipa eldipa added the enhancement something nice to have but it is not neither critical nor urgent label Oct 31, 2021
eldipa added a commit that referenced this issue Oct 31, 2021
…Progress-Bar

Issue #206: optionally disable the progress bar.
@eldipa eldipa added this to the 10.4.0 milestone Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement something nice to have but it is not neither critical nor urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant