Issue 176 support rust #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A possible edge race condition between an example that it is hung, byexample sending an abort (ctrl-C) but in that moment the example finishes and the signal is received by the interpreter that finishes also leading to an InterpreterClosedUnexpectedly. We cannot "fix" the RC but we can handle the case and print a message instead of an exception.
Some interpreter may have a race condition between the output generated by the example and the prompt printed by the interpreter. In those cases the output may appear *after* the prompt. This not only breaks the example (the last bits of the expected output are missing) but it also breaks the next example (unexpected bits are at the begin of the expected output). Assuming that the timming issue is quite small, we can add an optional delay after the prompt to capture more data at the end and try to keep the interpreter and byexample in sync.
The interpreter for Rust, evcxr, works quite well but it has a high runtime: 10-30 seconds for starting up the runner and 1-4 seconds for running each example. For now it is in experimental phase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #176