Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix match ResponseBody with $ref and no content #48

Merged
merged 4 commits into from
Apr 23, 2020
Merged

Fix match ResponseBody with $ref and no content #48

merged 4 commits into from
Apr 23, 2020

Conversation

domiTEN
Copy link

@domiTEN domiTEN commented Apr 21, 2020 •
edited
Loading

Hi,

I just found and error matching response bodies like this:

   response:
      '401':
         $ref: '#/components/responses/Unauthorized'

This is because the 'content' tag is not present and you suppose there is no body in the response.

@domiTEN domiTEN mentioned this pull request Apr 21, 2020
Open
byjg
byjg reviewed Apr 21, 2020
View reviewed changes
Copy link
Owner

@byjg byjg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a unit test testing the new feature?

src/OpenApi/OpenApiResponseBody.php Outdated Show resolved Hide resolved
@byjg byjg changed the base branch from master to 3.1 April 21, 2020 14:15
@byjg byjg self-assigned this Apr 21, 2020
@byjg
Copy link
Owner

byjg commented Apr 22, 2020

Thanks :) I'll take a look today.

@byjg byjg merged commit e2c0b34 into byjg:3.1 Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byjg byjg byjg left review comments

Assignees

@byjg byjg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@domiTEN @byjg @domingojimenez