Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use alternate approach for restart.sh #5

Closed
1 task
bymayanksingh opened this issue Sep 20, 2019 · 11 comments
Closed
1 task

Use alternate approach for restart.sh #5

bymayanksingh opened this issue Sep 20, 2019 · 11 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed KWoC

Comments

@bymayanksingh
Copy link
Owner

  • Give more controls to the user in the game window itself.
@agarwalshivani23
Copy link
Contributor

can i work on this issue?

@bymayanksingh
Copy link
Owner Author

@agarwalshivani23 yes

@Satvinder31415
Copy link
Contributor

I've started some work on this issue as well. If anyone else is working on it, I'll be happy to discuss and collaborate.

@agarwalshivani23
Copy link
Contributor

agarwalshivani23 commented Dec 6, 2019 via email

@Satvinder31415
Copy link
Contributor

@code-monk08 @agarwalshivani23
Hi, I've made some changes to implement the start menu and restart option. They're present in one of my repositories : connect4-2. Running main_menu.py will start the application(with a black screen currently).Pressing enter will launch the game.After the game is over,pressing y will restart while n will quit the game.Feel free to modify the code and add graphics(currently there are none). Also, bear in mind that this version is 2 commits behind the original one. I don't feel confident implementing graphics and mouse interactivity so I think that'll be the end of my contribution to this issue.

@Satvinder31415 Satvinder31415 removed their assignment Dec 10, 2019
@bymayanksingh
Copy link
Owner Author

@Satvinder31415 do one thing push your branch, I will ask @agarwalshivani23 to continue work from there.

@bymayanksingh
Copy link
Owner Author

bymayanksingh commented Dec 10, 2019

@Satvinder31415 but why are you feeling under confident?

@Satvinder31415
Copy link
Contributor

Satvinder31415 commented Dec 10, 2019 via email

@bymayanksingh
Copy link
Owner Author

ahh ! no issues we can improve whatever you design.. after all it's all about being creative, I will suggest you to try your hand again at this issue, bare minimum graphics will also do :)

@Satvinder31415
Copy link
Contributor

I'm currently doing unit testing. I'll come back to this.

@bymayanksingh bymayanksingh added enhancement New feature or request help wanted Extra attention is needed labels Dec 11, 2019
agarwalshivani23 added a commit to agarwalshivani23/connect4 that referenced this issue Dec 12, 2019
agarwalshivani23 added a commit to agarwalshivani23/connect4 that referenced this issue Dec 12, 2019
@bymayanksingh
Copy link
Owner Author

@Satvinder31415 I have recently merged @agarwalshivani23 's pull request and I am closing this issue, if you still want to add start menu to the game then I am looking forward to your PR, you can check the updated code and look if it helps you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed KWoC
Projects
None yet
Development

No branches or pull requests

3 participants