Implementation of support for different transports (other than Http) #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaveRMaltby
commented
Oct 31, 2022
| var variables = ({context.RequestExecutorInputSymbol.ToGlobalName()})variablesObject; | ||
| var qlResponse = await qlClient.QueryPipeline.ExecuteAsync<{context.QueryTypeName}>(qlClient.Transport, queryKey, variablesObject, queryRequest => | ||
| {{ | ||
| if (qlClient.Transport is HttpTransport) |
There was a problem hiding this comment.
Not happy about having a special condition here just for the HttpTransport, but with the code generation involved here on line 54, creating an abstraction that the HttpTransport instance would have to call into seemed more complicated (but still workable, if you would like the extra efforts)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal here is to have integration tests that still use the full Hot Chocolate pipeline, but don't require a TCP endpoint to be stood up. Besides avoiding the network layer here, it further avoids having to have a background service (or process) running the server-side of things and (if your GraphQL requires it) removes authentication issues as well.